linux-kernel - Re: [PATCH TRIVIAL] sched: Fix comments in struct root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131115100715.GE2965@twins.programming.kicks-ass.net>
Date:	Fri, 15 Nov 2013 11:07:15 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH TRIVIAL] sched: Fix comments in struct root_domain

On Fri, Nov 15, 2013 at 02:28:37PM +0530, Kamalesh Babulal wrote:
> Move comments related to RT overload, above rto_count.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
> ---
>  kernel/sched/sched.h | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 88c85b21d633..ca452e63f203 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -372,19 +372,18 @@ struct rt_rq {
>   * fully partitioning the member cpus from any other cpuset. Whenever a new
>   * exclusive cpuset is created, we also create and attach a new root-domain
>   * object.
> - *
>   */
>  struct root_domain {
>  	atomic_t refcount;
> -	atomic_t rto_count;
> -	struct rcu_head rcu;
> -	cpumask_var_t span;
> -	cpumask_var_t online;

The span and online mask aren't actually related to the overload muck.

>  
>  	/*
>  	 * The "RT overload" flag: it gets set if a CPU has more than
>  	 * one runnable RT task.
>  	 */
> +	atomic_t rto_count;
> +	struct rcu_head rcu;
> +	cpumask_var_t span;
> +	cpumask_var_t online;
>  	cpumask_var_t rto_mask;
>  	struct cpupri cpupri;
>  };
> -- 
> 1.8.4.474.g128a96c
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/