linux-kernel - Re: [PATCH] perf script: Print callchains and symbols if they exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFTL4hzam5NSZPKvh0yxXjZPmPLPGwQ5aMiuJeONUa1nbXWpUw@mail.gmail.com>
Date:	Fri, 15 Nov 2013 13:08:59 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	David Ahern <dsahern@...il.com>
Cc:	Arnaldo Melo <acme@...stprotocols.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf script: Print callchains and symbols if they exist

2013/11/15 David Ahern <dsahern@...il.com>:
> The intent of perf-script is to dump the events and information
> in the file. H/W, S/W and raw events all dump callchains if they
> are present; might as well make that the default for tracepoints
> too.
>
> Signed-off-by: David Ahern <dsahern@...il.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> ---
>  tools/perf/builtin-script.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index baf17989a216..6f96f8414047 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -99,7 +99,9 @@ static struct {
>
>                 .fields = PERF_OUTPUT_COMM | PERF_OUTPUT_TID |
>                                   PERF_OUTPUT_CPU | PERF_OUTPUT_TIME |
> -                                 PERF_OUTPUT_EVNAME | PERF_OUTPUT_TRACE,
> +                                 PERF_OUTPUT_EVNAME | PERF_OUTPUT_TRACE |
> +                             PERF_OUTPUT_IP | PERF_OUTPUT_SYM |
> +                                 PERF_OUTPUT_DSO,


Right it's important to dump callchains on tracepoint by default.

DSO are not important though because tracepoints always happen in the
kernel anyway. Although there is uprobes now hmm....

Same for ip/sym, most of the time the ip where the event happened is
not that relevant because it's often called from a same helper.
If SYM is required to dump callchains, I suggest that we only enable
SYM when callchains are present. Or have a seperate PERF_OUTPOUT
symbol for that may be.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/