linux-kernel - Re: [PATCH v3 05/15] KVM: MMU: update spte and add it into rmap before dirty log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131115000847.GA7219@amt.cnet>
Date:	Thu, 14 Nov 2013 22:08:47 -0200
From:	Marcelo Tosatti <mtosatti@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
Cc:	gleb@...hat.com, avi.kivity@...il.com, pbonzini@...hat.com,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v3 05/15] KVM: MMU: update spte and add it into rmap
 before dirty log

On Wed, Oct 23, 2013 at 09:29:23PM +0800, Xiao Guangrong wrote:
> kvm_vm_ioctl_get_dirty_log() write-protects the spte based on the its dirty
> bitmap, so we should ensure the writable spte can be found in rmap before the
> dirty bitmap is visible. Otherwise, we clear the dirty bitmap but fail to
> write-protect the page which is detailed in the comments in this patch
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
> ---
>  arch/x86/kvm/mmu.c | 84 ++++++++++++++++++++++++++++++++++++++++++------------
>  arch/x86/kvm/x86.c | 10 +++++++
>  2 files changed, 76 insertions(+), 18 deletions(-)

Reviewed-by: Marcelo Tosatti <mtosatti@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/