linux-kernel - Re: [PATCH 0/6] list: introduce list_last_entry_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131115141100.GA17659@infradead.org>
Date:	Fri, 15 Nov 2013 06:11:00 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Jeff Liu <jeff.liu@...cle.com>
Cc:	linux-kernel@...r.kernel.org, jfs-discussion@...ts.sourceforge.net,
	jiri@...nulli.us, gregkh@...uxfoundation.org, oleg@...hat.com,
	"xfs@....sgi.com" <xfs@....sgi.com>, cluster-devel@...hat.com,
	linux-mtd@...ts.infradead.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 0/6] list: introduce list_last_entry_or_null()

On Fri, Nov 15, 2013 at 12:29:48PM +0800, Jeff Liu wrote:
> Hi Folks,
> 
> This patch is trying to introduce a new list helper to retrieve the
> last entry or return NULL if the list is empty corresponding to it,
> which is inspired by Jiri Pirko's list_first_entry_or_null().

How did we end up with the stupid _or_null prefix there?  I think the
functionality is useful, but the naming is way to verbose, especially
given that a list_first_entry or list_last_entry that optimizes away
that one check doesn't seem useful.

Instead of encoding detailed semantics in the name a good kerneldoc
comment is way better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/