[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <52859845.2020101@realsil.com.cn>
Date: Fri, 15 Nov 2013 11:43:01 +0800
From: micky <micky_ching@...lsil.com.cn>
To: Lee Jones <lee.jones@...aro.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <sameo@...ux.intel.com>
CC: <linus.walleij@...aro.org>
Subject: Re: [PATCH 1/4] mfd: rtsx: Generify call-back operations in orderto reduce code duplication
On 11/14/2013 05:29 PM, Lee Jones wrote:
> + if (rtl8411b_is_qfn48(pcr))
> + set_pull_ctrl_tables(rtl8411b_qfn48);
> + else
> + set_pull_ctrl_tables(rtl8411b_qfn64);
Here will cause some problem, set_pull_ctrl_tables() include not a single
statements, will make the if-else not work correctly.
--
Best Regards
Micky.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists