linux-kernel - RE: [PATCH] staging: dwc2: do not clear pending interrupts twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A2CA0424C0A6F04399FB9E1CD98E030458E26C20@US01WEMBX2.internal.synopsys.com>
Date:	Fri, 15 Nov 2013 19:59:29 +0000
From:	Paul Zimmerman <Paul.Zimmerman@...opsys.com>
To:	Julien DELACOU <julien.delacou@...com>,
	Matthijs Kooijman <matthijs@...in.nl>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Grant Likely" <grant.likely@...aro.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: RE: [PATCH] staging: dwc2: do not clear pending interrupts twice

> From: Julien DELACOU [mailto:julien.delacou@...com]
> Sent: Friday, November 15, 2013 2:40 AM
> 
> Pending interrupts clearing is done in dwc2_enable_common_interrupts
> so we don't need to do it twice.
> 
> Signed-off-by: Julien Delacou <julien.delacou@...com>
> ---
>  drivers/staging/dwc2/core.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
> index c8ff668..8374ec3 100644
> --- a/drivers/staging/dwc2/core.c
> +++ b/drivers/staging/dwc2/core.c
> @@ -533,9 +533,6 @@ void dwc2_enable_host_interrupts(struct dwc2_hsotg *hsotg)
>  	writel(0, hsotg->regs + GINTMSK);
>  	writel(0, hsotg->regs + HAINTMSK);
> 
> -	/* Clear any pending interrupts */
> -	writel(0xffffffff, hsotg->regs + GINTSTS);
> -
>  	/* Enable the common interrupts */
>  	dwc2_enable_common_interrupts(hsotg);
> 
> --

Acked-by: Paul Zimmerman <paulz@...opsys.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/