[<prev] [next>] [day] [month] [year] [list]
Message-ID: <5285A464.1070904@oracle.com>
Date: Fri, 15 Nov 2013 12:34:44 +0800
From: Jeff Liu <jeff.liu@...cle.com>
To: linux-kernel@...r.kernel.org
CC: akpm@...ux-foundation.org, "xfs@....sgi.com" <xfs@....sgi.com>,
cluster-devel@...hat.com, linux-mtd@...ts.infradead.org,
jfs-discussion@...ts.sourceforge.net, oleg@...hat.com,
jiri@...nulli.us, gregkh@...uxfoundation.org
Subject: [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()
From: Jie Liu <jeff.liu@...cle.com>
Simplify the code in lmNextPage via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@...cle.com>
---
fs/jfs/jfs_logmgr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
* write or queue the full page at the tail of write queue
*/
/* get the tail tblk on commit queue */
- if (list_empty(&log->cqueue))
- tblk = NULL;
- else
- tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+ tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
/* every tblk who has COMMIT record on the current page,
* and has not been committed, must be on commit queue
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists