linux-kernel - Re: [PATCH] cpufreq: OMAP: Fix compilation error 'r & ret undeclared'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5914011.HGqL7cXjSj@vostro.rjw.lan>
Date:	Sat, 16 Nov 2013 02:12:10 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	linaro-kernel@...ts.linaro.org, patches@...aro.org,
	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, santosh.shilimkar@...com
Subject: Re: [PATCH] cpufreq: OMAP: Fix compilation error 'r & ret undeclared'

On Wednesday, November 13, 2013 03:39:23 PM Viresh Kumar wrote:
> With a recent change "d4019f0 cpufreq: move freq change notifications to cpufreq
> core" few variables (r & ret) are removed by mistake and hence these warnings:
> 
> drivers/cpufreq/omap-cpufreq.c: In function omap_target:
> drivers/cpufreq/omap-cpufreq.c:64:2: error: ret undeclared (first use in this function)
> drivers/cpufreq/omap-cpufreq.c:64:2: note: each undeclared identifier is reported only once for each function it appears in
> drivers/cpufreq/omap-cpufreq.c:94:3: error: r undeclared (first use in this function)
> drivers/cpufreq/omap-cpufreq.c:116:1: warning: control reaches end of non-void function [-Wreturn-type]
> 
> Lets fix them by declaring those variables again.
> 
> Reported-by: Sebastian Capella <sebastian.capella@...aro.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Queued up for the next PM pull request, thanks!

> ---
>  drivers/cpufreq/omap-cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c
> index be6d143..a0acd0b 100644
> --- a/drivers/cpufreq/omap-cpufreq.c
> +++ b/drivers/cpufreq/omap-cpufreq.c
> @@ -53,6 +53,7 @@ static unsigned int omap_getspeed(unsigned int cpu)
>  
>  static int omap_target(struct cpufreq_policy *policy, unsigned int index)
>  {
> +	int r, ret;
>  	struct dev_pm_opp *opp;
>  	unsigned long freq, volt = 0, volt_old = 0, tol = 0;
>  	unsigned int old_freq, new_freq;
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/