linux-kernel - Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1384640335.7518.12.camel@fishsauce>
Date:	Sat, 16 Nov 2013 16:18:55 -0600
From:	Ashley Lai <adlai@...ux.vnet.ibm.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	tpmdd-devel@...ts.sourceforge.net, Peter Huewe <peterhuewe@....de>,
	linux-kernel@...r.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to
 /dev/tpmX into tpm-dev.c

Nice clean up!!! The code looks much more clean after removing the
duplicated code in all drivers.  Thanks.


> diff --git a/drivers/char/tpm/tpm-dev.c b/drivers/char/tpm/tpm-dev.c
> new file mode 100644
> index 0000000..8d94e97
> --- /dev/null
> +++ b/drivers/char/tpm/tpm-dev.c
> + * Copyright (C) 2013 Obsidian Reearch Corp

Typo Research?

> + * Jason Gunthorpe <jgunthorpe@...idianresearch.com>
> + *

> +
> +int tpm_dev_add_device(struct tpm_chip *chip)
> +{

> +	rc = misc_register(&chip->vendor.miscdev);
> +	if (rc) {
> +		chip->vendor.miscdev.name = NULL;
> +		dev_warn(chip->dev,

Any reason why we use dev_warn here instead of dev_err?

> +			"unable to misc_register %s, minor %d err=%d\n",
> +			 chip->vendor.miscdev.name,
> +			 chip->vendor.miscdev.minor, rc);
> +	}
> +	return rc;
> +}
> +

Reviewed-by: Ashley Lai <adlai@...ux.vnet.ibm.com>

Regards,
--Ashley Lai

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/