linux-kernel - Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131117001236.GA22861@obsidianresearch.com>
Date:	Sat, 16 Nov 2013 17:12:36 -0700
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Ashley Lai <adlai@...ux.vnet.ibm.com>
Cc:	tpmdd-devel@...ts.sourceforge.net, Peter Huewe <peterhuewe@....de>,
	linux-kernel@...r.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to
 /dev/tpmX into tpm-dev.c

On Sat, Nov 16, 2013 at 04:18:55PM -0600, Ashley Lai wrote:
> Nice clean up!!! The code looks much more clean after removing the
> duplicated code in all drivers.  Thanks.

> > +++ b/drivers/char/tpm/tpm-dev.c
> > + * Copyright (C) 2013 Obsidian Reearch Corp
> 
> Typo Research?

Yes, thanks :)
 
> > + * Jason Gunthorpe <jgunthorpe@...idianresearch.com>
> > + *
> 
> > +
> > +int tpm_dev_add_device(struct tpm_chip *chip)
> > +{
> 
> > +	rc = misc_register(&chip->vendor.miscdev);
> > +	if (rc) {
> > +		chip->vendor.miscdev.name = NULL;
> > +		dev_warn(chip->dev,
> 
> Any reason why we use dev_warn here instead of dev_err?

Indeed, it was dev_err before I moved it. 

Hmm, it has been so long.. I think an earlier draft had
tpm_dev_add_device return void (like in other subsystems), so warn
made more sense. However I eventually changed it to propogate errors,
and didn't catch the flip.

Lets put it back.

Thanks!
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/