linux-kernel - [RFC] possible null dereference in 'pm121_create_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAGG-pUTye8ovBDvryN7GNPPCUmPJf9VhQ_hCbxJ9ABmz787H8A@mail.gmail.com>
Date:	Sun, 17 Nov 2013 17:10:27 -0200
From:	Geyslan Gregório Bem <geyslan@...il.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, linuxppc-dev@...ts.ozlabs.org
Subject: [RFC] possible null dereference in 'pm121_create_sys_fans()'

Hello Benjamin,

In file 'windfarm_pm121'.c:

If this branch is true:

    if (param == NULL) {
        printk(KERN_WARNING "pm121: %s fan config not found "
               " for this machine model\n",
               loop_names[loop_id]);
        goto fail;
    }

control that is NULL will suffer a dereference attempt:

fail:
    /* note that this is not optimal since another loop may still
       control the same control */
    printk(KERN_WARNING "pm121: failed to set up %s loop "
           "setting \"%s\" to max speed.\n",
           loop_names[loop_id], control->name);


Reported-by: Geyslan G. Bem <geyslan@...il.com>

-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/