[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <528828E7.6060404@roeck-us.net>
Date: Sat, 16 Nov 2013 18:24:39 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: "ivan.khoronzhuk" <ivan.khoronzhuk@...com>,
Santosh Shilimkar <santosh.shilimkar@...com>, wim@...ana.be,
nsekhar@...com, linux-watchdog@...r.kernel.org,
devicetree@...r.kernel.org
CC: grant.likely@...aro.org, rob.herring@...xeda.com,
pawel.moll@....com, mark.rutland@....com, swarren@...dotorg.org,
galak@...nel.crashing.org, ijc+devicetree@...lion.org.uk,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: Fwd: [PATCH 4/8] watchdog: davinci: add GET_STATUS option support
On 11/06/2013 03:32 AM, ivan.khoronzhuk wrote:
> When watchdog timer is expired we can know about it thought
thought -> through or with
> GET_STATUS ioctl option.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...com>
> ---
> drivers/watchdog/davinci_wdt.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
> index 6cbf2e1..a371b2d 100644
> --- a/drivers/watchdog/davinci_wdt.c
> +++ b/drivers/watchdog/davinci_wdt.c
> @@ -144,6 +144,18 @@ static unsigned int davinci_wdt_get_timeleft(struct watchdog_device *wdd)
> return wdd->timeout - timer_counter;
> }
>
> +static unsigned int davinci_wdt_status(struct watchdog_device *wdd)
> +{
> + u32 val;
> + struct davinci_wdt_device *davinci_wdt = watchdog_get_drvdata(wdd);
> +
> + val = ioread32(davinci_wdt->base + WDTCR);
> + if (val & WDFLAG)
> + return WDIOF_CARDRESET;
> +
"Card previously reset the CPU"
Is this really accurate / correct ?
My understanding is that the status is supposed to return the reason for a previous reset/reboot,
not the curent condition.
> + return 0;
> +}
> +
> static const struct watchdog_info davinci_wdt_info = {
> .options = WDIOF_KEEPALIVEPING,
> .identity = "DaVinci Watchdog",
> @@ -155,6 +167,7 @@ static const struct watchdog_ops davinci_wdt_ops = {
> .stop = davinci_wdt_ping,
> .ping = davinci_wdt_ping,
> .get_timeleft = davinci_wdt_get_timeleft,
> + .status = davinci_wdt_status,
> };
>
> static int davinci_wdt_probe(struct platform_device *pdev)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists