linux-kernel - Re: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131117121809.GC3093@katana>
Date:	Sun, 17 Nov 2013 13:18:09 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Andreas Werner <wernerandy@....de>
Cc:	khali@...ux-fr.org, jacmet@...site.dk, hskinnemoen@...il.com,
	dianders@...omium.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in
 syslog if no ACK received


> Is there another reason why pch_i2c_getack returned EPROTO?
> May be ENXIO was introduced later?

Imperfect review :)

> I think we can just replace the -EIO with -ENXIO or do you want to pick up the return
> vale of pch_i2c_getack and return that ?

The latter. As a rule of thumb, it is usually more sustainable to pass
through error codes. Overloading them should only be done when really
necessary IMO.


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)