linux-kernel - Re: [PATCH] [media] radio-shark: Mark shark_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5288C74D.7070206@redhat.com>
Date:	Sun, 17 Nov 2013 14:40:29 +0100
From:	Hans de Goede <hdegoede@...hat.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>
CC:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] radio-shark: Mark shark_resume_leds() inline
 to kill compiler warning

Hi,

On 10/28/2013 01:16 PM, Geert Uytterhoeven wrote:
> If SHARK_USE_LEDS=1, but CONFIG_PM=n:
>
> drivers/media/radio/radio-shark.c:275: warning: ‘shark_resume_leds’ defined but not used
>
> Instead of making the #ifdef logic even more complicated (there are already
> two definitions of shark_resume_leds()), mark shark_resume_leds() inline to
> kill the compiler warning. shark_resume_leds() is small and it has only one
> caller.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> {cris,m68k,parisc,sparc,xtensa}-all{mod,yes}config
>
>   drivers/media/radio/radio-shark.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/radio/radio-shark.c b/drivers/media/radio/radio-shark.c
> index b91477212413..050b3bb96fec 100644
> --- a/drivers/media/radio/radio-shark.c
> +++ b/drivers/media/radio/radio-shark.c
> @@ -271,7 +271,7 @@ static void shark_unregister_leds(struct shark_device *shark)
>   	cancel_work_sync(&shark->led_work);
>   }
>
> -static void shark_resume_leds(struct shark_device *shark)
> +static inline void shark_resume_leds(struct shark_device *shark)
>   {
>   	if (test_bit(BLUE_IS_PULSE, &shark->brightness_new))
>   		set_bit(BLUE_PULSE_LED, &shark->brightness_new);
>

Thanks for the patch. I've added this to my tree for 3.13 .

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/