linux-kernel - Re: xen drivers fail to link on ARM with v3.12-9888-gf63c482

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1311171616470.4714@kaball.uk.xensource.com>
Date:	Sun, 17 Nov 2013 16:18:29 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Josh Boyer <jwboyer@...oraproject.org>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Russell King <linux@....linux.org.uk>,
	<xen-devel@...ts.xenproject.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: xen drivers fail to link on ARM with v3.12-9888-gf63c482

On Sat, 16 Nov 2013, Josh Boyer wrote:
> On Sat, Nov 16, 2013 at 9:56 AM, Josh Boyer <jwboyer@...oraproject.org> wrote:
> > Hi All,
> >
> > The xen-gntalloc, xen-netfront, xen-blkfront, and xen-netback drivers
> > fail to link on ARM today with the following error:
> >
> > ERROR: "phys_to_mach" [drivers/xen/xen-gntalloc.ko] undefined!
> > ERROR: "phys_to_mach" [drivers/net/xen-netfront.ko] undefined!
> > ERROR: "phys_to_mach" [drivers/net/xen-netback/xen-netback.ko] undefined!
> > ERROR: "phys_to_mach" [drivers/block/xen-blkfront.ko] undefined!
> >
> > This is with Linus' tree as of this morning.
> >
> > I'm guessing this is because the mfn_to_pfn and pfn_to_mfn functions
> > are inlined and reference phys_to_mach directly, and that isn't
> > exported to modules.  Thoughts?
> 
> The patch below seems to fix this, but I'm not sure it's the desired
> approach.  I added the export for mach_to_phys just in case.
> 

Thank you for letting me know of the problem and thank you for the
patch!


> diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
> index 23732cd..7772fa8 100644
> --- a/arch/arm/xen/p2m.c
> +++ b/arch/arm/xen/p2m.c
> @@ -27,7 +27,9 @@ struct xen_p2m_entry {
> 
>  rwlock_t p2m_lock;
>  struct rb_root phys_to_mach = RB_ROOT;
> +EXPORT_SYMBOL_GPL(phys_to_mach);
>  static struct rb_root mach_to_phys = RB_ROOT;
> +EXPORT_SYMBOL_GPL(mach_to_phys);
> 

The approach is OK but mach_to_phys should not be exported.
Can you please resent the patch only exporting phys_to_mach and with
your signed-off-by line so that I can send it to Linus as soon as
possible?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/