linux-kernel - Re: [PATCH 2/3] mfd: cros ec: spi: Increase EC transaction delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131118104343.GG13640@lee--X1>
Date:	Mon, 18 Nov 2013 10:43:43 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Derek Basehore <dbasehore@...omium.org>
Subject: Re: [PATCH 2/3] mfd: cros ec: spi: Increase EC transaction delay

On Mon, 18 Nov 2013, Thierry Reding wrote:

> From: Derek Basehore <dbasehore@...omium.org>
> 
> 50 us is not a long enough delay between EC transactions. At least 70 us
> are needed for the 16 MHz STM32L part. Increase the delay to 200 us for
> an extra safety margin.
> 
> Signed-off-by: Derek Basehore <dbasehore@...omium.org>
> Reviewed-by: Randall Spangler <rspangler@...omium.org>
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>  drivers/mfd/cros_ec_spi.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

As I'm sure you've tested this and you didn't notice any new undue
latency, I'll apply the patch, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/