linux-kernel - Re: [PATCH] brcmsmac: Fix build dep on LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Nov 2013 12:58:58 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Arend van Spriel <arend@...adcom.com>
Cc:	Borislav Petkov <bp@...en8.de>,
	lkml <linux-kernel@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013/11/17 Arend van Spriel <arend@...adcom.com>:
> On 11/17/13 14:37, Borislav Petkov wrote:
>>
>> From: Borislav Petkov<bp@...e.de>
>>
>> When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get
>>
>> drivers/built-in.o: In function `brcms_led_unregister':
>> (.text+0x351aca): undefined reference to `led_classdev_unregister'
>> drivers/built-in.o: In function `brcms_led_register':
>> (.text+0x351c65): undefined reference to `led_classdev_register'
>>
>> during the final linking stage because brcmsmac/led.c needs LEDS_CLASS
>> for reg/dereg. Fix that.
>
>
> Wouldn't it be better to fix it in brcmsmac.

I agree. After all bcma doesn't use/register LEDs, so this should be
placed in drivers that do.

P.S.
Borislav: I think I didn't get your original patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/