linux-kernel - Re: [RFC 03/23] OMAPDSS: raw read and write endian fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <528A1272.5060905@ti.com>
Date:	Mon, 18 Nov 2013 15:13:22 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Taras Kondratiuk <taras.kondratiuk@...aro.org>,
	<linux-omap@...r.kernel.org>
CC:	<linaro-networking@...aro.org>,
	Victor Kamensky <victor.kamensky@...aro.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 03/23] OMAPDSS: raw read and write endian fix

On 2013-11-16 02:01, Taras Kondratiuk wrote:
> From: Victor Kamensky <victor.kamensky@...aro.org>
> 
> All OMAP IP blocks expect LE data, but CPU may operate in BE mode.
> Need to use endian neutral functions to read/write h/w registers.
> I.e instead of __raw_read[lw] and __raw_write[lw] functions code
> need to use read[lw]_relaxed and write[lw]_relaxed functions.
> If the first simply reads/writes register, the second will byteswap
> it if host operates in BE mode.
> 
> Changes are trivial sed like replacement of __raw_xxx functions
> with xxx_relaxed variant.
> 

Looks fine to me. Quick test with o4 panda works fine.

Acked-by: Tomi Valkeinen <tomi.valkeinen@...com>

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)