linux-kernel - Re: [PATCH] arm/xen: Export phys_to_mach to fix Xen module link errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1311181402160.4714@kaball.uk.xensource.com>
Date:	Mon, 18 Nov 2013 14:02:52 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Josh Boyer <jwboyer@...hat.com>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	<xen-devel@...ts.xenproject.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] arm/xen: Export phys_to_mach to fix Xen module link
 errors

On Mon, 18 Nov 2013, Josh Boyer wrote:
> Various xen drivers fail to link when built as modules with the following
> error:
> 
> ERROR: "phys_to_mach" [drivers/xen/xen-gntalloc.ko] undefined!
> ERROR: "phys_to_mach" [drivers/net/xen-netfront.ko] undefined!
> ERROR: "phys_to_mach" [drivers/net/xen-netback/xen-netback.ko] undefined!
> ERROR: "phys_to_mach" [drivers/block/xen-blkfront.ko] undefined!
> 
> The mfn_to_pfn and pfn_to_mfn functions get inlined in these modules and
> those functions require phys_to_mach.  Export the symbol to fix the link
> errors.
> 
> Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>

Reviewed-by: Stefano Stabellini <stefano.stabellini@...citrix.com>


>  arch/arm/xen/p2m.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
> index 23732cd..0f842e8 100644
> --- a/arch/arm/xen/p2m.c
> +++ b/arch/arm/xen/p2m.c
> @@ -27,6 +27,7 @@ struct xen_p2m_entry {
>  
>  rwlock_t p2m_lock;
>  struct rb_root phys_to_mach = RB_ROOT;
> +EXPORT_SYMBOL_GPL(phys_to_mach);
>  static struct rb_root mach_to_phys = RB_ROOT;
>  
>  static int xen_add_phys_to_mach_entry(struct xen_p2m_entry *new)
> -- 
> 1.8.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/