linux-kernel - Re: [PATCH] scripts/config: allow setting a string which value contains a colon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131118180619.GA3458@free.fr>
Date:	Mon, 18 Nov 2013 19:06:19 +0100
From:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
To:	Clement Chauplannaz <chauplac@...il.com>
Cc:	linux-kbuild@...r.kernel.org, mmarek@...e.cz,
	sedat.dilek@...il.com, linus.walleij@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/config: allow setting a string which value
 contains a colon

Clément, All,

On 2013-11-17 12:55 +0100, Clement Chauplannaz spake thusly:
> A bug in script `config' prevented from modifying an existing variable's
> value to a string that contains a colon ':'.  The reason behind it is that
> colons are used as a separator in `sed' commands that script `config'
> relies on.
> 
> Escape colons in `sed' commands to allow values containing colons.
> 
> Signed-off-by: Clement Chauplannaz <chauplac@...il.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@...e.fr>

It'll be in my tree soon, as a rc-fix. Thank you.

Regards,
Yann E. MORIN.

> ---
>  scripts/config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/config b/scripts/config
> index 6804179..4b16260 100755
> --- a/scripts/config
> +++ b/scripts/config
> @@ -78,7 +78,7 @@ txt_append() {
>  
>  txt_subst() {
>  	local before="$1"
> -	local after="$2"
> +	local after="${2//:/\:}"
>  	local infile="$3"
>  	local tmpfile="$infile.swp"
>  
> -- 
> 1.8.3.2.dirty
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/