linux-kernel - Re: [PATCH v2] panic: Make panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131118143059.afe17d2faced16171a05eb10@linux-foundation.org>
Date:	Mon, 18 Nov 2013 14:30:59 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jason Baron <jbaron@...mai.com>
Cc:	mingo@...nel.org, benh@...nel.crashing.org, paulus@...ba.org,
	ralf@...ux-mips.org, linux-kernel@...r.kernel.org,
	Felipe Contreras <felipe.contreras@...il.com>
Subject: Re: [PATCH v2] panic: Make panic_timeout configurable

On Mon, 18 Nov 2013 21:04:36 +0000 (GMT) Jason Baron <jbaron@...mai.com> wrote:

> The panic_timeout value can be set via the command line option 'panic=x', or via
> /proc/sys/kernel/panic, however that is not sufficient when the panic occurs
> before we are able to set up these values. Thus, add a CONFIG_PANIC_TIMEOUT
> so that we can set the desired value from the .config.
> 
> The default panic_timeout value continues to be 0 - wait forever, except for
> powerpc and mips, which have been defaulted to 180 and 5 respectively. This
> is in keeping with the fact that these arches already set panic_timeout in
> their arch init code. However, I found three exceptions- two in mips and one in
> powerpc where the settings didn't match these default values. In those cases, I
> left the arch code so it continues to override, in case the user has not changed
> from the default. It would nice if these arches had one default value, or if we
> could determine the correct setting at compile-time.

Felipe is proposing a simpler patch ("panic: setup panic_timeout
early") which switches to early_param().  Is that sufficient for the
(undescribed!) failure which you are presumably observing?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/