linux-kernel - Re: [RFC] drivers/scsi/dc395x.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1384761220.30084.9.camel@linux-fkkt.site>
Date:	Mon, 18 Nov 2013 08:53:40 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Geyslan Gregório Bem <geyslan@...il.com>
Cc:	Ali Akcaagac <aliakc@....de>, Jamie Lenehan <lenehan@...bble.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	dc395x@...bble.org, LKML <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org, hch@...radead.org
Subject: Re: [RFC] drivers/scsi/dc395x.c - msgin_qtag()

On Fri, 2013-11-15 at 17:53 -0200, Geyslan Gregório Bem wrote:

Hi,

> Hi guys,
> 
> In the function msgin_qtag() [line 2632], this dereference was intentional?
> 
> static struct ScsiReqBlk *msgin_qtag(struct AdapterCtlBlk *acb,
>         struct DeviceCtlBlk *dcb, u8 tag)
> {
>     struct ScsiReqBlk *srb = NULL;
>     struct ScsiReqBlk *i;
>     dprintkdbg(DBG_0, "msgin_qtag: (0x%p) tag=%i srb=%p\n",
>            srb->cmd, tag, srb);
> ...
> 
> There is a srb (NULL) dereference in the dprintkdbg() parameteres.

That is a bad bug.

> If not, what approach do you suggest me for a patch?

Merge it with
        dprintkdbg(DBG_0, "msgin_qtag: (0x%p) <%02i-%i>\n",
                srb->cmd, srb->dcb->target_id, srb->dcb->target_lun);
later in the function.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/