linux-kernel - Re: [patch] perf/trace properly use u64 to hold event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131118085335.GC3866@twins.programming.kicks-ass.net>
Date:	Mon, 18 Nov 2013 09:53:35 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Vince Weaver <vincent.weaver@...ne.edu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [patch] perf/trace properly use u64 to hold event_id

On Fri, Nov 15, 2013 at 12:39:45PM -0500, Vince Weaver wrote:
> 
> The 64-bit attr.config value for perf trace events was being copied into
> an "int" before doing a comparison, meaning the top 32 bits were
> being truncated.
> 
> As far as I can tell this didn't cause any errors, but it did mean
> it was possible to create valid aliases for all the tracepoint ids
> which I don't think was intended.  (For example, 0xffffffff00000018
> and 0x18 both enable the same tracepoint).
> 
> Signed-off-by: Vince Weaver <vincent.weaver@...ne.edu>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/