linux-kernel - Re: [PATCH] x86: boot: Fix mixed indentation in a20.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131119103408.GA3640@pd.tnic>
Date:	Tue, 19 Nov 2013 11:34:08 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Johannes Löthberg <johannes@...iasis.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: boot: Fix mixed indentation in a20.c

On Tue, Nov 19, 2013 at 08:22:41AM +0100, Ingo Molnar wrote:
> 
> * H. Peter Anvin <hpa@...or.com> wrote:
> 
> > On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
> > > Replace all mixed indentation with tabs
> > > 
> > > Signed-off-by: Johannes Löthberg <johannes@...iasis.com>
> > 
> > NAK.  Not worth the churn in the absence of other changes.
> 
> Yes.
> 
> If a20.c was cleaned up altogether, that might be a more tempting 
> change, it has a good number of inconsistencies and improving it all 
> would make it more readable.
>  
> But it makes little sense to do an incomplete cleanup.

Yeah, senseless cleanup without any benefit whatsoever (yeah, fuck
readability! :-)) should be forbidden, if you ask me. Especially
since it dilutes and muds up git history and finding the patch which
introduced a change turns into a serious undertaking.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/