linux-kernel - Re: [PATCH] lib/crc32: slice by 4 is more efficient than the default slice by 8 on Powerpc 8xx.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF5004EA63.AA9B7989-ONC1257C28.004D6C13-C1257C28.004DF922@transmode.se>
Date:	Tue, 19 Nov 2013 15:11:40 +0100
From:	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
To:	Christophe Leroy <christophe.leroy@....fr>
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	Marcelo Tosatti <marcelo@...ck.org>,
	Bob Pearson <rpearson@...temfabricworks.com>,
	Vitaly Bordug <vitb@...nel.crashing.org>
Subject: Re: [PATCH] lib/crc32: slice by 4 is more efficient than the default slice
 by 8 on Powerpc 8xx.

I found the same on MPC8321 long time ago(when 64 bits change went in), 
the 32 bits were much faster. I guess the "smaller"
CPUs cannot handle the cache trashing these big tables impose, I didn't 
look into the details though.
So I think this is a good change for 8xx.

Acked-by: Joakim Tjernlund <joakim.tjernlund@...nsmode.se>

Christophe Leroy <christophe.leroy@....fr> wrote on 2013/11/18 08:04:23:

> From: Christophe Leroy <christophe.leroy@....fr>
> To: Vitaly Bordug <vitb@...nel.crashing.org>, Marcelo Tosatti 
<marcelo@...ck.org>, Joakim Tjernlund <joakim.tjernlund@...nsmode.se>, Bob 
Pearson <rpearson@...temfabricworks.com>, 
> Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
> Date: 2013/11/19 13:05
> Subject: [PATCH] lib/crc32: slice by 4 is more efficient than the 
default slice by 8 on Powerpc 8xx.
> 
> On PPC_8xx, CRC32_SLICEBY4 is more efficient (almost twice) than 
CRC32_SLICEBY8,
> as shown below:
> 
> With CRC32_SLICEBY8:
> [    1.109204] crc32: CRC_LE_BITS = 64, CRC_BE BITS = 64
> [    1.114401] crc32: self tests passed, processed 225944 bytes in 
15118910 nsec
> [    1.130655] crc32c: CRC_LE_BITS = 64
> [    1.134235] crc32c: self tests passed, processed 225944 bytes in 
4479879 nsec
> 
> With CRC32_SLICEBY4:
> [    1.097129] crc32: CRC_LE_BITS = 32, CRC_BE BITS = 32
> [    1.101878] crc32: self tests passed, processed 225944 bytes in 
8616242 nsec
> [    1.116298] crc32c: CRC_LE_BITS = 32
> [    1.119607] crc32c: self tests passed, processed 225944 bytes in 
3289576 nsec
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
> 
> Index: a/lib/Kconfig
> ===================================================================
> --- a/lib/Kconfig   (rÃ©vision 5325)
> +++ b/lib/Kconfig   (copie de travail)
> @@ -102,6 +102,7 @@
>  choice
>     prompt "CRC32 implementation"
>     depends on CRC32
> +   default CRC32_SLICEBY4 if PPC_8xx
>     default CRC32_SLICEBY8
>     help
>       This option allows a kernel builder to override the default choice

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/