linux-kernel - Re: net/usb/ax88179_178a driver broken in linux-3.12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1384870550.8604.101.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 19 Nov 2013 06:15:50 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Mark Lord <mlord@...ox.com>
Cc:	David Laight <David.Laight@...LAB.COM>,
	Ming Lei <ming.lei@...onical.com>, davem@...emloft.net,
	netdev@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: net/usb/ax88179_178a driver broken in linux-3.12

On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote:
> On 13-11-19 05:04 AM, David Laight wrote:
> >> From: Mark Lord
> ..
> >> except the ax88179_178a driver still does not work in linux-3.12,
> >> whereas it works fine in all earlier kernels.
> >>
> >> That's a regression.
> >> And a simple revert (earlier in this thread) fixes it.
> >> So.. let's revert it for now, until a proper xhci compatible patch is produced.
> ...
> > There is a patch to xhci-ring.c that should fix the SG problem.
> > http://www.spinics.net/lists/linux-usb/msg97176.html
> > 
> > I think it should apply to the 3.12 sources.
> 
> I am running with that patch here now (thanks),
> and it too appears to prevent the lockups.
> 
> But is this patch upstream already?
> If yes, then it needs to get pushed out to -stable for 3.12 at least.
> 
> If not upstream, then the revert is probably safest for -stable,
> rather than new code that has never been upstream before.
> 

> Both patches are attached to this email.
> One or the other is required for the USB 3.0 network adapters to function in 3.12.

I do not see any error in commit f27070158d6754765f2
("ax88179_178a: avoid copy of tx tcp packets")

Quite the contrary in fact...

I suspect a TSO bug, and would rather disable TSO for this nic.

Have you tried to revert 3804fad45411b482
("USBNET: ax88179_178a: enable tso if usb host supports sg dma")



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/