linux-kernel - Re: [PATCH 9/9] staging/lustre/ldlm: fix resource/fid check, use DLDLMRES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131119184053.GA19358@kroah.com>
Date:	Tue, 19 Nov 2013 10:40:53 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Peng Tao <bergwolf@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Lai Siyao <lai.siyao@...el.com>
Subject: Re: [PATCH 9/9] staging/lustre/ldlm: fix resource/fid check, use
 DLDLMRES

On Tue, Nov 19, 2013 at 09:23:48PM +0800, Peng Tao wrote:
> From: Andreas Dilger <andreas.dilger@...el.com>
> 
> In ll_md_blocking_ast() the FID/resource comparison is incorrectly
> checking for fid_ver() stored in res_id.name[2] instead of name[1]
> changed since http://review.whamcloud.com/2271 (commit 4f91d5161d00)
> landed.  This does not impact current clients, since name[2] and
> fid_ver() are always zero, but it could cause problems in the future.
> 
> In ldlm_cli_enqueue_fini() use ldlm_res_eq() instead of comparing
> each of the resource fields separately.
> 
> Use DLDLMRES/PLDLMRES when printing resource names everywhere.

There are codingstyle warnings in this patch, please fix before
resending.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/