lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Nov 2013 23:55:28 +0100 From: Linus Walleij <linus.walleij@...aro.org> To: Daniel Lezcano <daniel.lezcano@...aro.org> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Lee Jones <lee.jones@...aro.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/2] ARM: ux500: decomission the non-DT MTU init sequence On Tue, Nov 19, 2013 at 11:40 PM, Daniel Lezcano <daniel.lezcano@...aro.org> wrote: > On 11/19/2013 10:27 PM, Linus Walleij wrote: >> - if (!of_have_populated_dt()) >> - nmdk_timer_init(mtu_timer_base, IRQ_MTU0); > > If no timer have been defined in the dt [or wrongly defined], is there a > message to tell the user what is wrong ? Isn't that a question to be asked about a whole lot of such clocksource drivers and ARM platforms? Most DT-only ARM platforms rely on arch/arm/kernel/time.c to call clocksource_of_init() if the machine_desc->init_time() hook is not set and has zero code to handle any such situation. So I guess what you're asking is whether we should patch clocksource_of_init() to warn if it cannot find any matching clock sources, like this: >From e55cf038b238d96b28d9fb01b5b6cdf345990d53 Mon Sep 17 00:00:00 2001 From: Linus Walleij <linus.walleij@...aro.org> Date: Tue, 19 Nov 2013 23:52:56 +0100 Subject: [PATCH] clksrc-of: warn if no clock sources are found Many platforms rely on clocksource_of_init() being implicitly called for registering clock sources and will get zero warnings if no working clock source is available. Let's print a critical error message if no clock source is found. Signed-off-by: Linus Walleij <linus.walleij@...aro.org> --- drivers/clocksource/clksrc-of.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/clocksource/clksrc-of.c b/drivers/clocksource/clksrc-of.c index 35639cf4e5a2..a30b42c3ac3b 100644 --- a/drivers/clocksource/clksrc-of.c +++ b/drivers/clocksource/clksrc-of.c @@ -28,6 +28,7 @@ void __init clocksource_of_init(void) struct device_node *np; const struct of_device_id *match; clocksource_of_init_fn init_func; + unsigned clocksources = 0; for_each_matching_node_and_match(np, __clksrc_of_table, &match) { if (!of_device_is_available(np)) @@ -36,5 +37,8 @@ void __init clocksource_of_init(void) init_func = match->data; init_func(np); of_node_put(np); + clocksources++; } + if (!clocksources) + pr_crit("%s: no matching clocksources found\n", __func__); } -- 1.8.3.1 You can apply this by itself to get the desired warning. Tell me if you want me to send the patch separately. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists