linux-kernel - Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131120.004026.2013972041095203460.davem@davemloft.net>
Date:	Wed, 20 Nov 2013 00:40:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	freddy@...x.com.tw
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, davemloft@...emloft.net,
	louis@...x.com.tw, allan@...x.com.tw, grundler@...gle.com,
	daniel@...x.com.tw
Subject: Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B
 under ChromeOS

From: freddy@...x.com.tw
Date: Wed, 20 Nov 2013 10:11:36 +0800

> From: Freddy Xin <freddy@...x.com.tw>
> 
> This patch adds a workaroud to solve Suspend/Resume issue that AX88772B turns
> off its Ethernet PHY power in the case that REMOTE_WAKEUP feature doesn't
> be set when system suspend. In this case, the PHY power will not be turned
> on again when system resume, so the HW reset must be added in the resume function.
> 
> Signed-off-by: Freddy Xin <freddy@...x.com.tw>
> Tested-by: Grant Grundler <grundler@...omium.org>

Like many similar patches I've seen recently, you cannot do this.

Now the the configuration that software things the PHY has is no
longer accurate.

If you absolutely must reset the chip on resume, you have to reprogram
the PHY with whatever settings were existed at the time of the suspend.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/