linux-kernel - Re: [PATCH] Expose sysctls for enabling slab/file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHGf_=py9fq51viTx1RfmAMf=t=TX=86nb8h6F7nW7qw=pCRow@mail.gmail.com>
Date:	Wed, 20 Nov 2013 00:49:16 -0500
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Michal Hocko <mhocko@...e.cz>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Expose sysctls for enabling slab/file_cache interleaving

On Tue, Nov 19, 2013 at 4:49 PM, Andi Kleen <andi@...stfloor.org> wrote:
> Michal Hocko <mhocko@...e.cz> writes:
>>
>> Another option would be to use sysctl values for the top cpuset as a
>> default. But then why not just do it manually without sysctl?
>
> I want to provide an alternative to having to use cpusets to use this,
> that is actually usable for normal people.
>
> Also this is really a global setting in my mind.
>
>> If you create a cpuset and explicitly disable spreading then you would
>> be quite surprised that your process gets pages from all nodes, no?
>
> If I enable it globally using a sysctl I would be quite surprised
> if some cpuset can override it.
>
> That argument is equally valid :-)
>
> The user configured an inconsistent configuration, and the kernel
> has to make a decision somehow.
>
> In the end it is arbitary, but not having to check the cpuset
> here is a lot cheaper, so I prefer the "sysctl has priority"
> option.

sorry.
I agree with Michael. If there are large scope knob and small scope knob,
the small scope should have high priority. It is one of best practice of the
interface design.

However, I fully agree the basic concept of this patch. sysctl help a
lot of admins.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/