lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Nov 2013 09:26:42 +0000 From: "Jan Beulich" <JBeulich@...e.com> To: "Bob Liu" <bob.liu@...cle.com> Cc: <ian.campbell@...rix.com>, "Bob Liu" <lliubbo@...il.com>, <xen-devel@...ts.xenproject.org>, <konrad.wilk@...cle.com>, <linux-kernel@...r.kernel.org>, <keir@....org> Subject: Re: [PATCH] xen: tmem: rmove useless parameters >>> On 20.11.13 at 10:22, Bob Liu <bob.liu@...cle.com> wrote: > On 11/20/2013 05:10 PM, Jan Beulich wrote: >>>>> On 20.11.13 at 09:52, Bob Liu <lliubbo@...il.com> wrote: >>> @@ -100,9 +100,6 @@ static inline int xen_tmem_op(u32 tmem_cmd, u32 > tmem_pool, struct tmem_oid oid, >>> op.u.gen.oid[1] = oid.oid[1]; >>> op.u.gen.oid[2] = oid.oid[2]; >>> op.u.gen.index = index; >>> - op.u.gen.tmem_offset = tmem_offset; >>> - op.u.gen.pfn_offset = pfn_offset; >>> - op.u.gen.len = len; >> >> But you can't leave these fields uninitialized. >> > > Oh, yes. > And I should remove those members totally from struct tmem_op {} That's an established ABI - you can't just remove members there. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists