lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Nov 2013 11:59:42 -0800 From: Tony Luck <tony.luck@...il.com> To: Thomas Gleixner <tglx@...utronix.de> Cc: LKML <linux-kernel@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>, "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Andi Kleen <ak@...ux.intel.com>, Peter Anvin <hpa@...or.com>, Mike Galbraith <bitbucket@...ine.de>, Arjan van de Ven <arjan@...ux.intel.com>, Frederic Weisbecker <fweisbec@...il.com>, Fenghua Yu <fenghua.yu@...el.com> Subject: Re: [patch 4/6] ia64: Use preempt_schedule_irq On Tue, Sep 17, 2013 at 11:53 AM, Thomas Gleixner <tglx@...utronix.de> wrote: > Use the proper core function instead of fiddling with PREEMPT_ACTIVE > and enable/disable interrupts in the low level code. > > Index: linux-2.6/arch/ia64/kernel/entry.S > =================================================================== > --- linux-2.6.orig/arch/ia64/kernel/entry.S > +++ linux-2.6/arch/ia64/kernel/entry.S ... > - br.call.spnt.many rp=schedule > + br.call.spnt.many rp=preempt_schedule_irq This just hit mainline ... and I'm getting arch/ia64/kernel/built-in.o: In function `skip_rbs_switch': (.text+0xef2): undefined reference to `preempt_schedule_irq' make: *** [vmlinux] Error 1 Probably because I have CONFIG_PREEMPT=n, and there seems only to be a definition for this function in kernel/sched/core.c when it is =y. Do we need a stub for the =n case: asmlinkage void __sched preempt_schedule_irq(void) { schedule(); } Or is life more complicated than that? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists