lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Nov 2013 12:11:35 -0800 From: Matt Wilson <msw@...ux.com> To: xen-devel@...ts.xenproject.org Cc: Matt Wilson <msw@...zon.com>, Stefano Stabellini <stefano.stabellini@...citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, David Vrabel <david.vrabel@...rix.com>, Anthony Liguori <aliguori@...zon.com>, linux-kernel@...r.kernel.org Subject: [PATCH] xen/gnttab: leave lazy MMU mode in the case of a m2p override failure From: Matt Wilson <msw@...zon.com> Commit f62805f1 introduced a bug where lazy MMU mode isn't exited if a m2p_add/remove_override call fails. Cc: Stefano Stabellini <stefano.stabellini@...citrix.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com> Cc: David Vrabel <david.vrabel@...rix.com> Cc: Anthony Liguori <aliguori@...zon.com> Cc: xen-devel@...ts.xenproject.org Cc: linux-kernel@...r.kernel.org Signed-off-by: Matt Wilson <msw@...zon.com> --- drivers/xen/grant-table.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 62ccf54..0283871 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -930,9 +930,10 @@ int gnttab_map_refs(struct gnttab_map_grant_ref *map_ops, ret = m2p_add_override(mfn, pages[i], kmap_ops ? &kmap_ops[i] : NULL); if (ret) - return ret; + goto out; } + out: if (lazy) arch_leave_lazy_mmu_mode(); @@ -969,9 +970,10 @@ int gnttab_unmap_refs(struct gnttab_unmap_grant_ref *unmap_ops, ret = m2p_remove_override(pages[i], kmap_ops ? &kmap_ops[i] : NULL); if (ret) - return ret; + goto out; } + out: if (lazy) arch_leave_lazy_mmu_mode(); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists