linux-kernel - Re: mmotm 2013-11-20-16-13 uploaded (arch/um/kernel/sysrq.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4049956.nmFOrVzcI3@sandpuppy>
Date:	Thu, 21 Nov 2013 09:15:38 +0100
From:	Richard Weinberger <richard@....at>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	akpm@...ux-foundation.org, mm-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-fsdevel@...r.kernel.org, linux-next@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: mmotm 2013-11-20-16-13 uploaded (arch/um/kernel/sysrq.c)

Am Mittwoch, 20. November 2013, 16:52:05 schrieb Randy Dunlap:
> On 11/20/13 16:14, akpm@...ux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2013-11-20-16-13 has been uploaded to
> > 
> >    http://www.ozlabs.org/~akpm/mmotm/
> > 
> > mmotm-readme.txt says
> > 
> > README for mm-of-the-moment:
> > 
> > http://www.ozlabs.org/~akpm/mmotm/
> > 
> > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > more than once a week.
> 
> on i386:
> (with um i386 defconfig)
> 
> arch/um/kernel/sysrq.c:22:13: error: expected identifier or '(' before 'do'
> um/kernel/sysrq.c:22:13: error: expected identifier or '(' before 'while'
> 
> 
> so sysrq.c is picking up <linux/stacktrace.h> somehow and not liking it.

um/kernel/sysrq.c has
static void print_stack_trace(unsigned long *sp, unsigned long bp)
and linux/stracktrace.h has
# define print_stack_trace(trace, spaces)               do { } while (0)

So um's print_stack_trace needs to be renamed.
Thanks a lot for reporting!

Thanks,
//richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/