linux-kernel - Re: [PATCH] ARM: shmobile: Add pinctrl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131121083849.GA2732@verge.net.au>
Date:	Thu, 21 Nov 2013 17:38:50 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH] ARM: shmobile: Add pinctrl_register_mappings() for
 Koelsch

On Thu, Nov 21, 2013 at 01:05:57PM +0900, Simon Horman wrote:
> On Wed, Nov 20, 2013 at 04:41:48PM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm@...nsource.se>
> > 
> > Add code to setup the r8a7791 PFC for the Koelsch board.
> > 
> > At this point serial consoles are added, and in the near
> > future other platform-device-only devices will be added
> > here like for instance the r8a7791 DU.
> > 
> > Signed-off-by: Magnus Damm <damm@...nsource.se>
> > ---
> > 
> >  arch/arm/mach-shmobile/board-koelsch.c |   12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> 
> Thanks, I will queue this up.
> Assuming all goes will I plan to push this and other updates
> today or tomorrow.

Unfortunately with this patch applied I am no longer
able to boot my Koelsch board using the koelsch defconfig.
Am I missing something?

I am dropping this patch for now.

> 
> > 
> > --- 0014/arch/arm/mach-shmobile/board-koelsch.c
> > +++ work/arch/arm/mach-shmobile/board-koelsch.c	2013-11-20 16:18:28.000000000 +0900
> > @@ -24,6 +24,7 @@
> >  #include <linux/input.h>
> >  #include <linux/kernel.h>
> >  #include <linux/leds.h>
> > +#include <linux/pinctrl/machine.h>
> >  #include <linux/platform_data/gpio-rcar.h>
> >  #include <linux/platform_device.h>
> >  #include <mach/common.h>
> > @@ -78,9 +79,20 @@ static const struct gpio_keys_platform_d
> >  	.nbuttons	= ARRAY_SIZE(gpio_buttons),
> >  };
> >  
> > +static const struct pinctrl_map koelsch_pinctrl_map[] = {
> > +	/* SCIF0 (CN19: DEBUG SERIAL0) */
> > +	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.6", "pfc-r8a7791",
> > +				  "scif0_data_d", "scif0"),
> > +	/* SCIF1 (CN20: DEBUG SERIAL1) */
> > +	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7791",
> > +				  "scif1_data_d", "scif1"),
> > +};
> > +
> >  static void __init koelsch_add_standard_devices(void)
> >  {
> >  	r8a7791_clock_init();
> > +	pinctrl_register_mappings(koelsch_pinctrl_map,
> > +				  ARRAY_SIZE(koelsch_pinctrl_map));
> >  	r8a7791_pinmux_init();
> >  	r8a7791_add_standard_devices();
> >  	platform_device_register_data(&platform_bus, "leds-gpio", -1,
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/