linux-kernel - Re: [PATCH] drivers: clocksource: Hide arm_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5ha9gyi00k.wl%tiwai@suse.de>
Date:	Thu, 21 Nov 2013 10:20:43 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
	daniel.lezcano@...aro.org, will.deacon@....com,
	catalin.marinas@....com, olof@...om.net,
	sudeep.karkadanagesha@....com
Subject: Re: [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

At Wed, 20 Nov 2013 12:02:03 -0800,
Stephen Boyd wrote:
> 
> Pavel Machek reports that this config is exposed on x86 where the
> ARM architected timers aren't even present. Make it depend on the
> ARM architected timers being selected so that non-ARM builds
> aren't asked about it.
> 
> Reported-by: Pavel Machek <pavel@....cz>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>  drivers/clocksource/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index bdb953e..5c07a56 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -87,6 +87,7 @@ config ARM_ARCH_TIMER
>  config ARM_ARCH_TIMER_EVTSTREAM
>  	bool "Support for ARM architected timer event stream generation"
>  	default y if ARM_ARCH_TIMER
> +	depends on ARM_ARCH_TIMER

We can drop "if ARM_ARCH_TIMER" in "default y" line now.
But do we need "default y" at the first place?


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/