| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1579156.ZV84FQEURS@vostro.rjw.lan> Date: Thu, 21 Nov 2013 01:32:33 +0100 From: "Rafael J. Wysocki" <rjw@...ysocki.net> To: Toshi Kani <toshi.kani@...com> Cc: HATAYAMA Daisuke <d.hatayama@...fujitsu.com>, lenb@...nel.org, linux-acpi@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] sysfs, acpi, tables: Set file size for each ACPI table On Wednesday, November 20, 2013 03:38:55 PM Toshi Kani wrote: > On Tue, 2013-11-19 at 17:54 +0900, HATAYAMA Daisuke wrote: > > Currently, each of the ACPI tables exported from > > /sys/firmware/acpi/tables is of zero size: > > > > $ LANG=C ls -ld /sys/firmware/acpi/tables/* > > -r-------- 1 root root 0 Nov 19 09:48 /sys/firmware/acpi/tables/APIC > > -r-------- 1 root root 0 Nov 19 09:48 /sys/firmware/acpi/tables/BOOT > > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/DSDT > > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/FACP > > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/FACS > > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/MCFG > > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/SRAT > > drwxr-xr-x 2 root root 0 Nov 19 09:48 /sys/firmware/acpi/tables/dynamic/ > > > > due to which, user-land tools fail reading each table. For example: > > > > $ acpidump -f /sys/firmware/acpi/tables/SRAT > > Could not get input file size: /sys/firmware/acpi/tables/SRAT > > > > To deal with the issue, this patch assigns size of each ACPI table to > > the corresponding sysfs file. > > > > $ LANG=C ls -hld /sys/firmware/acpi/tables/* > > -r-------- 1 root root 94 Nov 19 16:45 /sys/firmware/acpi/tables/APIC > > -r-------- 1 root root 40 Nov 19 16:45 /sys/firmware/acpi/tables/BOOT > > -r-------- 1 root root 58K Nov 19 16:55 /sys/firmware/acpi/tables/DSDT > > -r-------- 1 root root 244 Nov 19 16:55 /sys/firmware/acpi/tables/FACP > > -r-------- 1 root root 64 Nov 19 16:55 /sys/firmware/acpi/tables/FACS > > -r-------- 1 root root 60 Nov 19 16:55 /sys/firmware/acpi/tables/MCFG > > -r-------- 1 root root 168 Nov 19 16:45 /sys/firmware/acpi/tables/SRAT > > drwxr-xr-x 2 root root 0 Nov 19 16:55 /sys/firmware/acpi/tables/dynamic/ > > > > Then, user-land tools work well like: > > > > $ acpidump -f /sys/firmware/acpi/tables/SRAT > > SRAT @ 0x0000000000000000 > > 0000: 53 52 41 54 A8 00 00 00 02 65 56 4D 57 41 52 45 SRAT.....eVMWARE > > 0010: 4D 45 4D 50 4C 55 47 20 00 00 04 06 56 4D 57 20 MEMPLUG ....VMW > > 0020: 01 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 ................ > > 0030: 01 28 00 00 00 00 00 00 00 00 00 00 00 00 00 00 .(.............. > > 0040: 00 00 0A 00 00 00 00 00 00 00 00 00 01 00 00 00 ................ > > 0050: 00 00 00 00 00 00 00 00 01 28 00 00 00 00 00 00 .........(...... > > 0060: 00 00 10 00 00 00 00 00 00 00 F0 BF 00 00 00 00 ................ > > 0070: 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 ................ > > 0080: 01 28 00 00 00 00 00 00 00 00 00 00 01 00 00 00 .(.............. > > 0090: 00 00 00 40 00 00 00 00 00 00 00 00 01 00 00 00 ...@............ > > 00A0: 00 00 00 00 00 00 00 00 ........ > > > > Signed-off-by: HATAYAMA Daisuke <d.hatayama@...fujitsu.com> > > Acked-by: Toshi Kani <toshi.kani@...com> Thanks! I've queued up the patch for the next ACPI pull request. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists