linux-kernel - Re: [PATCH] wm8994: avoid to enable dcs done irq before init completion dcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131121112301.GN2674@sirena.org.uk>
Date:	Thu, 21 Nov 2013 11:23:01 +0000
From:	Mark Brown <broonie@...nel.org>
To:	wangbiao <biao.wang@...el.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Vinod Koul <vinod.koul@...el.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, mingo@...e.hu,
	a.p.zijlstra@...llo.nl, akpm@...ux-foundation.org,
	di.zhang@...el.com
Subject: Re: [PATCH] wm8994: avoid to enable dcs done irq before init
 completion dcs_done

On Thu, Nov 21, 2013 at 09:22:58AM +0800, wangbiao wrote:

> From: wang, biao <biao.wang@...el.com>
> Date: Wed, 20 Nov 2013 17:53:28 +0800
> Subject: [PATCH] wm8994: avoid to enable dcs done irq before init completion dcs_done

Please don't include things like this in the body of your mail unless
you are overriding things in the header, submit things in the format
documented in SubmittingPatches.  This will avoid confusing tools used
to handle patches.

Please also try to send your mail to only relevant people, the CC list
above is very broad.  Many kernel developers get a lot of mail so it's
good to be sure that you know why everyone on the CC list is there.

> once code return from request_threaded_irq, irq was setup enabled by
> default, but completion var dcs_done not got initialized yet, if then a
> dcs done irq was raised, system will got hung as the sync mechanism is
> invalid now.

> so this patch try not enable irq when request it until we got things
> ready.

I would expect to see a patch such as this moving either the interrupt
request or (more likely) the completion init.  However that's not what
this patch does.  Why is this?  The most obvious thing here would be to
move the initialisation of the completion to the start of the probe()
function.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)