linux-kernel - Re: [PATCH] perf: Move fs.* to generic lib/lk/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131121114224.GA27704@gmail.com>
Date:	Thu, 21 Nov 2013 12:42:24 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Borislav Petkov <bp@...e.de>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Robert Richter <rric@...nel.org>
Subject: Re: [PATCH] perf: Move fs.* to generic lib/lk/


* Borislav Petkov <bp@...en8.de> wrote:

> On Thu, Nov 21, 2013 at 12:17:44PM +0100, Ingo Molnar wrote:
> > > However, now that I think of it, the naming is kinda imprecise 
> > > having only "kernel" in it - it only denotes that it is a library of 
> > > stuff that has grown in the kernel.
> > > 
> > > So how about
> > > 
> > > tools/lib/ktools/
> > > tools/lib/kutils/
> > > tools/lib/kernel-tools/
> > > tools/lib/kernel-utils/
> > > ...
> > > 
> > > and
> > > 
> > > libktools.so
> > > libkutils.so
> > > ...
> > > 
> > > ?
> > > 
> > > I'd prefer ktools as in the tools/ directory of the kernel repo.
> > 
> > So what does each name mean, what would they be used for and what's 
> > the difference between them?
> 
> Oh no, I'm only proposing multiple libraries but multiple names to 
> choose *only* *one* from them - the one which we think fits best.
> 
> Basically I wanna say: "this is the library of tools which grew in 
> the tools/ directory of the kernel repo".
> 
> Thus I'm proposing
> 
> 	tools/lib/ktools/
> 
> as a path and
> 
> 	libktools.so
> 
> as a library name, because, IMHO, this name is closer to the reality.
>
> tools/lib/kernel/ is also ok - it does not describe the collection 
> of functionality that precisely, IMHO, that's all.
> 
> Am I even making sense here?

Ok - so why not call it tools/lib/kernel/ or tools/lib/kernelapi/ or 
tools/lib/kapi/?

That's really what is common about it: it offers various helper 
methods to interface with the Linux kernel: debugfs, procfs, sysfs 
handling routines with no policy, just pure, obvious helpers to use 
kernel functionality.

[ Naming it 'ktools' is not optimal because these are already tools/ 
  ... the secondary meaning of 'tools' in that context is easily lost. 
  Same goes for 'kutils', the secondary meaning is confusing (to me). ]

... and just in case you are wondering why I'm making a fuss about it: 
a naming discussion for something fundamental as this isn't bikeshed 
painting, we really want people to look at that place to readily stuff 
kernel related helpers into, and the name should make that very 
obvious.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/