linux-kernel - Re: [PATCH] ARM: CCI : Fix implicit declaration of function error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131121125614.26955C40A2C@trevor.secretlab.ca>
Date:	Thu, 21 Nov 2013 12:56:14 +0000
From:	Grant Likely <grant.likely@...aro.org>
To:	Dave Martin <Dave.Martin@....com>,
	Majunath Goudar <csmanjuvijay@...il.com>
Cc:	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	Majunath Goudar <manju.goudar@....com>,
	linux-kernel@...r.kernel.org,
	Rob Herring <rob.herring@...xeda.com>, nataraja.km@....com
Subject: Re: [PATCH] ARM: CCI : Fix implicit declaration of function error

On Thu, 17 Oct 2013 13:12:28 +0100, Dave Martin <Dave.Martin@....com> wrote:
> On Mon, Oct 14, 2013 at 03:52:27PM +0530, Majunath Goudar wrote:
> > This patch adds a inline dummy implementations of_find_matching_node()
> > in "#ifdef CONFIG_OF" else part. Without this patch,build system can
> > lead to issues. This was discovered during randconfig testing,in which
> > ARM_CCI was enabled w/o CONFIG_OF being enabled,leading to the following error:
> 
> Without fetching config info from the DT, the CCI driver is not usable,
> so it makes no sense to build this driver without CONFIG_OF.

I agree here, and that is the big reason why I'm resistant to blanket
implementation of empty OF related functions. If those functions are
called, then most likely the code strongly depends on CONFIG_OF. Leaving
the blank ones out catches scenarios like this.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/