linux-kernel - Re: [PATCH] acpi: Incorrect ACPI tables walk in acpi_tables_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Nov 2013 14:27:22 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Jeremy Compostella <jeremy.compostella@...el.com>
Cc:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jeremy Compostella <jeremy.compostella@...il.com>,
	"Gross, Mark" <mark.gross@...el.com>
Subject: Re: [PATCH] acpi: Incorrect ACPI tables walk in acpi_tables_sysfs_init

On Thursday, November 21, 2013 11:20:27 AM Jeremy Compostella wrote:
> Date: Thu, 21 Nov 2013 11:20:23 +0100
> Message-ID: <87d2lu83a0.fsf@...lab276.tl.intel.com>
> MIME-Version: 1.0
> Content-Type: text/plain
> --text follows this line--
> Hi,
> 
> When executing on a ACPI Hardware reduced hardware, all the ACPI tables are not
> exposed in sysfs due to the fact that FACS is silently ignored by the kernel in
> ACPI hardware reduced and, moreover, the acpi_tables_sysfs_init ACPI table walk
> is buggy and stop too soon.
> 
> The acpi_tables_sysfs_init function should to rely on the appropriate
> acpi_status return values to decide or not to stop the iteration.  This way,
> when running on a ACPI Reduced Harware environment where the FACS table is
> silently ignored by the kernel or some ACPI table are not correctly memory
> mapped or have a bad checksum it would not stop the iteration.
> 
> Signed-off-by: Jeremy Compostella <jeremy.compostella@...el.com>

Since this is a fix, I've modified the subject and changelog slightly and
queued up the patch for the next ACPI pull request (next week).

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/