linux-kernel - Re: [PATCH 15/22] tools lib traceevent: Change pevent_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131121082841.5b709947@gandalf.local.home>
Date:	Thu, 21 Nov 2013 08:28:41 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 15/22] tools lib traceevent: Change pevent_parse_event
 to return event format

On Thu, 21 Nov 2013 12:01:13 +0100
Jiri Olsa <jolsa@...hat.com> wrote:

> Changing pevent_parse_event to return 'struct event_format',
> for the parsed event if the return pointer is specified.

Can we not change the API of pevent_parse_event(), I use it quite a bit.

And yes, I'm working hard to keep what's in trace-cmd and the kernel
identical.

> 
> This way we can remove pevent_parse_format which does the
> same stuff just without 'struct pevent' object.

Actually, I don't use pevent_parse_format() at all. What about changing
that one to include the pevent?


> 
> The ultimate goal is to always use pevent object when dealing
> with traceevent library. The reason is that we might need
> additional processing (like plugins), which is not possible
> otherwise.

Right, so add a pevent to the pevent_parse_format() and leave the
pevent_parse_event() alone. That should make everyone happy :-)

Thanks!

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/