linux-kernel - Re: [PATCH] of: unflatten_and_copy: handle NULL initial_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <528E0BBA.6050002@imgtec.com>
Date:	Thu, 21 Nov 2013 13:33:46 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Grant Likely <grant.likely@...aro.org>
CC:	Rob Herring <rob.herring@...xeda.com>,
	<devicetree@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: unflatten_and_copy: handle NULL initial_boot_params

On 21/11/13 12:39, Grant Likely wrote:
> On Tue, 19 Nov 2013 12:58:12 +0000, James Hogan <james.hogan@...tec.com> wrote:
>> Check whether initial_boot_params is NULL before dereferencing it in
>> unflatten_and_copy_device_tree() for the case where no device tree is
>> available but the arch can still boot to a minimal usable system without
>> it.
>>
>> Signed-off-by: James Hogan <james.hogan@...tec.com>
>> Cc: Grant Likely <grant.likely@...aro.org>
>> Cc: Rob Herring <rob.herring@...xeda.com>
>> Cc: devicetree@...r.kernel.org
>> Cc: linux-arch@...r.kernel.org
>> ---
>>  drivers/of/fdt.c | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
>> index 2fa024b97c43..ac4983955e6d 100644
>> --- a/drivers/of/fdt.c
>> +++ b/drivers/of/fdt.c
>> @@ -922,8 +922,14 @@ void __init unflatten_device_tree(void)
>>   */
>>  void __init unflatten_and_copy_device_tree(void)
>>  {
>> -	int size = __be32_to_cpu(initial_boot_params->totalsize);
>> -	void *dt = early_init_dt_alloc_memory_arch(size,
>> +	int size;
>> +	void *dt;
>> +
>> +	if (!initial_boot_params)
>> +		return;
> 
> Worth logging a message for those who can obtain the kernel log
> buffer?

Yes, sounds reasonable (especially since for Meta the platform name detected from DT doesn't get logged in this case and I still get the console out via JTAG probe).
I'll post a v2 adding this:

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index ac4983955e6d..758b4f8b30b7 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -925,8 +925,10 @@ void __init unflatten_and_copy_device_tree(void)
 	int size;
 	void *dt;
 
-	if (!initial_boot_params)
+	if (!initial_boot_params) {
+		pr_warn("No valid device tree found, continuing without\n");
 		return;
+	}
 
 	size = __be32_to_cpu(initial_boot_params->totalsize);
 	dt = early_init_dt_alloc_memory_arch(size,

> Otherwise:
> 
> Acked-by: Grant Likely <grant.likely@...aro.org>

Thanks
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/