linux-kernel - Re: [PATCH v3 3/5] staging: et131x: stop read when hit max delay in et131x_phy_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131121211939.GD10691@einon.net>
Date:	Thu, 21 Nov 2013 21:19:40 +0000
From:	Mark Einon <mark.einon@...il.com>
To:	ZHAO Gang <gamerh2o@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH v3 3/5] staging: et131x: stop read when hit max delay in
 et131x_phy_mii_read

On Wed, Nov 20, 2013 at 03:56:32PM +0800, ZHAO Gang wrote:
> stop read and return error when hit max delay time.
> 
> Signed-off-by: ZHAO Gang <gamerh2o@...il.com>

Acked-by: Mark Einon <mark.einon@...il.com>

> ---
>  drivers/staging/et131x/et131x.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index cda037a..6254a6b 100644
> --- a/drivers/staging/et131x/et131x.c
> +++ b/drivers/staging/et131x/et131x.c
> @@ -1392,6 +1392,7 @@ static int et131x_phy_mii_read(struct et131x_adapter *adapter, u8 addr,
>  			    mii_indicator);
>  
>  		status = -EIO;
> +		goto out;
>  	}
>  
>  	/* If we hit here we were able to read the register and we need to
> @@ -1399,6 +1400,7 @@ static int et131x_phy_mii_read(struct et131x_adapter *adapter, u8 addr,
>  	 */
>  	*value = readl(&mac->mii_mgmt_stat) & ET_MAC_MIIMGMT_STAT_PHYCRTL_MASK;
>  
> +out:
>  	/* Stop the read operation */
>  	writel(0, &mac->mii_mgmt_cmd);
>  
> -- 
> 1.8.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/