linux-kernel - Re: [PATCH] wimax: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385007469.2164.39.camel@joe-AO722>
Date:	Wed, 20 Nov 2013 20:17:49 -0800
From:	Joe Perches <joe@...ches.com>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	Johannes Berg <johannes.berg@...el.com>
Cc:	inaky.perez-gonzalez@...el.com, linux-wimax@...el.com,
	davem@...emloft.net, wimax@...uxwimax.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wimax: remove dead code

On Thu, 2013-11-21 at 04:43 +0100, Michael Opdenacker wrote:
> This removes a code line that is between a "return 0;" and an error label.
> This code line can never be reached.

Adding Johannes Berg who added this oversight.

> Found by Coverity (CID: 1130529)
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> ---
>  net/wimax/stack.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/wimax/stack.c b/net/wimax/stack.c
> index ef2191b969a7..ec8b577db135 100644
> --- a/net/wimax/stack.c
> +++ b/net/wimax/stack.c
> @@ -610,7 +610,6 @@ int __init wimax_subsys_init(void)
>  	d_fnend(4, NULL, "() = 0\n");
>  	return 0;
>  
> -	genl_unregister_family(&wimax_gnl_family);
>  error_register_family:
>  	d_fnend(4, NULL, "() = %d\n", result);
>  	return result;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/