linux-kernel - Re: [PATCH] tty: replace mutex_lock() with tty_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131122082525.GA5302@mwanda>
Date:	Fri, 22 Nov 2013 11:25:25 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Andreas Platschek <andi.platschek@...il.com>
Cc:	gregkh@...uxfoundation.org, jslaby@...e.cz,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] tty: replace mutex_lock() with tty_write_lock()

On Thu, Nov 21, 2013 at 08:12:12PM +0100, Andreas Platschek wrote:
> Use tty_write_lock()/tty_write_unlock() consistently.
> 
> This takes care of the following sparse warning:
> drivers/tty/tty_io.c:1169:17: warning: context imbalance in 'tty_write_message' - unexpected unlock
> 

I don't think we can do this.  mutex_lock() always succeeds and
tty_write_lock() can fail.

I think we just have to live with the error message.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/