linux-kernel - Re: [PATCHv4] ASoC: Add support for BCM2835

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131122140519.GN14725@sirena.org.uk>
Date:	Fri, 22 Nov 2013 14:05:19 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Florian Meier <florian.meier@...lo.de>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
	devicetree <devicetree@...r.kernel.org>,
	dmaengine <dmaengine@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCHv4] ASoC: Add support for BCM2835

On Fri, Nov 22, 2013 at 02:32:19PM +0100, Florian Meier wrote:
> > +	dev = devm_kzalloc(&pdev->dev, sizeof(*dev),
> > +			   GFP_KERNEL);
> > +	if (IS_ERR(base))
> > +		return PTR_ERR(base);

> Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev).

No, it should be a check for NULL and returning -ENOMEM.

> Is the patch acceptable apart from that now?

Not looked yet.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)