linux-kernel - Re: [PATCH] i915, debugfs: Fix uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131122150959.GD10036@intel.com>
Date:	Fri, 22 Nov 2013 17:09:59 +0200
From:	Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Richard Weinberger <richard.weinberger@...il.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	intel-gfx@...ts.freedesktop.org,
	LKML <linux-kernel@...r.kernel.org>,
	DRI mailing list <dri-devel@...ts.freedesktop.org>,
	Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH] i915, debugfs: Fix uninitialized warning

On Thu, Nov 21, 2013 at 05:25:35PM +0100, Borislav Petkov wrote:
> On Thu, Nov 21, 2013 at 05:10:30PM +0100, Richard Weinberger wrote:
> > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > > index 6ed45a984230..1191aa47adc9 100644
> > > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > > @@ -2347,7 +2347,7 @@ static int pipe_crc_set_source(struct drm_device *dev, enum pipe pipe,
> > >  {
> > >         struct drm_i915_private *dev_priv = dev->dev_private;
> > >         struct intel_pipe_crc *pipe_crc = &dev_priv->pipe_crc[pipe];
> > > -       u32 val;
> > > +       u32 val = 0; /* shut up gcc */
> > 
> > Wouldn't it be better to use uninitialized_var() here?
> 
> I remember Linus' rant about this macro so that's why I don't use it
> anymore.
> 
> In this specific case, it doesn't matter whichever we do so I'll let the
> maintainer make a wish :)

IIRC this warning was there for me too on gcc 4.6, but it disappeared
on gcc 4.7, which is why I decided not to send a patch for it.

-- 
Ville Syrjälä
Intel OTC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/