linux-kernel - Re: [PATCH 22/22] perf tools: Overload pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385135431.1747.125.camel@leonhard>
Date:	Sat, 23 Nov 2013 00:50:31 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 22/22] perf tools: Overload pr_stat traceevent print
 function

2013-11-21 (목), 12:01 +0100, Jiri Olsa:
> The traceevent lib uses pr_stat to display all standard
> info. It's defined as __weak. Overloading it with perf
> version plugged into perf output system logic.
> 
> Displaying the pr_stat stuff under '-v' option.

[SNIP]
>  
> +/*
> + * Overloading libtraceevent standard info print
> + * function, display with -v in perf.
> + */
> +void pr_stat(const char *fmt, ...)
> +{
> +	va_list args;
> +
> +	if (verbose >= 1) {
> +		va_start(args, fmt);
> +		vfprintf(stderr, fmt, args);
> +		fprintf(stderr, "\n");
> +		va_end(args);
> +	}
> +}

It'd be better if it use or does same as eprintf() like other pr_*
functions does.

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/