lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Nov 2013 19:38:54 +0100 From: Alexander Gordeev <agordeev@...hat.com> To: Tejun Heo <tj@...nel.org> Cc: linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, Michael Ellerman <michael@...erman.id.au>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Ben Hutchings <bhutchings@...arflare.com>, David Laight <David.Laight@...LAB.COM>, Mark Lord <kernel@...rt.ca>, "H. Peter Anvin" <hpa@...or.com>, linux-pci@...r.kernel.org Subject: Re: [PATCH RFC v2 11/29] PCI/MSI: Convert pci_msix_table_size() to a public interface On Wed, Nov 20, 2013 at 11:23:24AM -0500, Tejun Heo wrote: > On Fri, Oct 18, 2013 at 07:12:11PM +0200, Alexander Gordeev wrote: > > Make pci_msix_table_size() return error code if the device > > does not support MSI-X. This update is needed to create a > > consistent MSI-X counterpart for pci_get_msi_cap() MSI > > interface. > > > > Device drivers can use this interface to obtain maximum number > > of MSI-X interrupts the device supports and i.e. use that number > > in a following call to pci_enable_msix() interface. > > Please mention that the return value of the function has been changed > in the description. Also, do we want to rename it to > pci_get_msix_cap() for consistency? I do not think so. The naming explicitly hints PCI registers and pci_get_msix_cap() is confusing at least. I would leave it as is. > > Signed-off-by: Alexander Gordeev <agordeev@...hat.com> > > Reviewed-by: Tejun Heo <tj@...nel.org> > > Thanks. > > -- > tejun -- Regards, Alexander Gordeev agordeev@...hat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists